Clean up diff patch temporary file - #34069
Open
luojiyin1987 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
3 tasks
luojiyin1987
marked this pull request as ready for review
August 11, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #34067.
Summary
Register an EXIT trap for the RCS diff temporary file.
Remove the normal-path cleanup at the end.
The trap now handles every exit path.
Root cause
The script only removed the file after all commands succeeded.
The set -e option can stop the script before that cleanup.
Impact
Early failures and interruptions no longer leave the diff file behind.
Patch generation behavior stays unchanged.
Checks