FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support for device brand and model. by mspiegel · Pull Request #4 · ua-parser/uap-java · GitHub

/ uap-java Public

Support for device brand and model. - #4

Open
mspiegel wants to merge 4 commits into
ua-parser:masterfrom
mspiegel:master
ConversationCommits (4)ChecksFiles changed
Open

Support for device brand and model.#4
mspiegel wants to merge 4 commits into
ua-parser:masterfrom
mspiegel:master

Conversation

mspiegel commented Jan 15, 2015

Copy link
Copy Markdown

This pull request adds support for ua-parser/uap-core@3021618.
It also cleans up the hashCode() methods for the various classes.

Michael Spiegel added 4 commits January 15, 2015 16:51
Support for device brand and model.
a31de23
Simplify device parsing.
d19aae0 
Use Matcher#appendReplacement() and Matcher#appendTail()
to perform a single pass through the device replacement
in order to avoid edge cases where the order of
replacement changes the generated string.
Revert unnecessary changes to equals method.
6386a08
Finish cleanup of equals() method.
364375c

mmarmol commented May 12, 2015

Copy link
Copy Markdown

Any update on this merge?

BaiGang mentioned this pull request Oct 18, 2015
Closed

BaiGang commented Oct 18, 2015

Copy link
Copy Markdown

+1 and LGTM.

I'm looking forward to this improvement.

tmatei commented Nov 1, 2015

Copy link
Copy Markdown

any updates on this?

mmarmol commented Mar 1, 2016

Copy link
Copy Markdown

Hey @tmatei @BaiGang and @mspiegel I am currently working in a project that is bases on this lib but I am trying to put things up to date. For example I have a remote url load for the yaml and a scheduled load. I added this changes also, by the end of this week I will have also public maven repos so it can be easily included in projects. I would love to hear feedback from you.

https://github.com/mmarmol/uap-java

nsonntag mentioned this pull request Mar 18, 2016
Closed

hkkanuru commented Jun 14, 2017

Copy link
Copy Markdown

why was this merge reverted? just curious, we would like to get brand and model?

wangjy38 commented Jun 24, 2022

Copy link
Copy Markdown

Could this PR be reviewed again? device brand is useful in many circumstances

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

brand/model

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL