feat(stovepipe): tag controller metrics by queue - #630
Draft
mnoah1 wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mnoah1
force-pushed
the
mnoah1/stovepipe-queue-metric-scopes
branch
2 times, most recently
from
f27b81b to
ab4c26c
Compare
August 24, 2026 19:22
mnoah1
force-pushed
the
mnoah1/stovepipe-queue-metric-scopes
branch
2 times, most recently
from
ef97e0a to
4b2f50f
Compare
August 24, 2026 19:38
Summary: Intent: - Make controller metrics attributable to their logical queue. - Enforce request-local metric scoping without mutating shared controllers. Changes: - Add a metrics factory that resolves queue-bound scopes from explicit config. - Pass typed queue-scoped metrics through every primary and DLQ controller path. - Keep pre-decode failures explicitly unscoped and cover queue tags in tests. Test Plan: - Exercise primary and DLQ controller metric paths and assert emitted series carry the expected queue tag. - Run the affected packages with the Go race detector and targeted Bazel tests. Revert Plan: - Revert this commit to restore the prior unscoped controller metrics. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
force-pushed
the
mnoah1/stovepipe-queue-metric-scopes
branch
from
4b2f50f to
0a71da9
Compare
August 24, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Test Plan
Revert Plan
Generated by the 🪄 pr-create skill in devexp-agent-marketplace
Issues