FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add zh-TW supported by ycy-0510 · Pull Request #332 · ueman/feedback · GitHub

/ feedback Public

add zh-TW supported - #332

Open
ycy-0510 wants to merge 4 commits into
ueman:masterfrom
ycy-0510:master
Open

add zh-TW supported#332
ycy-0510 wants to merge 4 commits into
ueman:masterfrom
ycy-0510:master

Conversation

Copy link
Copy Markdown

📜 Description

  • add zh-TW by ZhTWFeedbackLocalizations
  • add ZhTWFeedbackLocalizations to supportedLocales
  • add locale full check in load function in l18n/translation.dart

💡 Motivation and Context

The package hasn't supported Traditional Chinese, but some people (or kids) in Asia weren't used to use Simplified Chinese. Therefore add a new language to this useful package is important and required to help people that use flutter apps with this package all over the world easily.

💚 How did you test it?

I tested them with my simple app and test/l18n/feedback_l18n_test.dart

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

ycy-0510 requested a review from ueman as a code owner October 27, 2024 09:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL