support Bun - #70
Open
Songmu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for developing such wonderful OSS.
When I ran create-create-app using Bun, the following error occurred.
$ bun create create-app hoge (node:49250) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead. (Use `node --trace-deprecation ...` to show where the warning was created) ? Description description ? Author name Songmu ? Author email y.songmu@gmail.com ? Template default ? License MIT Creating a new package in /Users/Songmu/temporary/work-20250204-195056/create-hoge. Initializing a git repository > git init Installing the latest version of create-create-app # TypeError s is not iterable (cannot read property undefined) TypeError: s is not iterable (cannot read property undefined) at K (/private/tmp/bunx-501-create-create-app@latest/node_modules/create-create-app/lib/cli.js:2:2100) at _ (/private/tmp/bunx-501-create-create-app@latest/node_modules/create-create-app/lib/cli.js:5:76) at after (/private/tmp/bunx-501-create-create-app@latest/node_modules/create-create-app/lib/cli.js:20:336) at le (/private/tmp/bunx-501-create-create-app@latest/node_modules/create-create-app/lib/cli.js:5:351) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) # Environment - create-create-app: 7.3.0 - System > OS: macOS 15.3 - Binaries > Node: 22.4.0 - ~/.local/share/mise/installs/node/22.4.0/bin/node If you think this is a bug, please report at https://github.com/uetchy/create-create-app/issues along with the information above.This is because create-create-app does not support Bun as a package manager.
In the pull request, I supported Bun and added error handling within the switch statement to make the error message easier to understand.
It is up to you to decide whether or not we should support Bun.