build: remove non existing node.import condition - #115
Merged
pi0 merged 1 commit intoFeb 7, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pi0
approved these changes
Feb 7, 2024
pi0
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice find! Thanks for investigation ❤️
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#114
❓ Type of change
Remove the node.import statement from package.json since proxy is only provided in commonJS format, resulting in build errors with Bun.
📚 Description
Since the proxy is not included in a esm format, it results in the bundlers (Bun in the case of the issue), to throw an error about a missing export.
📝 Checklist