fix: escape () and [] in scan directory globs - #627
Conversation
Sorry, something went wrong.
|
|
Sorry, something went wrong.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4063450d96
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
| ? dirs.flatMap(dir => normalizeScanDirs([dir], { | ||
| ...dirsScanOptions, | ||
| cwd: root, | ||
| })).map(dir => ({ ...dir, glob: escapeGlobPathChars(dir.glob) })) |
There was a problem hiding this comment.
Preserve user-supplied glob syntax when escaping paths
When dirs or dirsScanOptions.filePatterns intentionally contains parentheses or a character class (for example, dirs: ['src/[ab]'] or filePatterns: ['*.[jt]s']), this post-normalization replacement escapes that syntax along with the literal project-root portion. Both directory scanning and the precompiled HMR matchers then look for literal brackets/parentheses instead of the requested glob matches, so previously supported configurations stop discovering exports. Escape only the literal resolved path prefix while preserving the user-supplied glob expression.
Useful? React with 👍 / 👎.
Sorry, something went wrong.
Project paths like Code(Template) were treated as picomatch extglob groups, so dir scanning and HMR watchers matched nothing.
Summary
Fixes #416
Test plan
Made with Cursor