feat(kcl): switch to kcl - #43
Draft
haarchri wants to merge 2 commits into
Draft
haarchri wants to merge 2 commits into
haarchri wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
3 tasks
haarchri
marked this pull request as draft
July 18, 2024 10:48
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
haarchri
commented
Jul 23, 2024
Comment thread
apis/main.k
| resourceInclusions: get(oxr, "spec.parameters.operators.argocd.resourceInclusions", "") | ||
| }, | ||
| } | ||
| } if get(_ocds, "kubernetes.Resource", {}) and get(oxr, "spec.parameters.operators.argocd.enabled", "") and all_true([ |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
we need to add an OR to prevent deletion when kubernetes cluster switched back to false
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
ToDo
Fixes #
I have:
How has this code been tested