feat(compose lint): support lint compose policies - #2288
Draft
v1v wants to merge 2 commits into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for the pullrequest, having this checks within the Updatecli command make sense. I don't have a better solution at the moment, for info I am considering renaming a few command cfr #1879 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #XXX
Replace shell scripting in https://github.com/updatecli/policies/blob/main/.ci/scripts/release.bash#L41-L122 with a CLI command, for such I decided to use updatecli compose lint <path>.
I have yet to implement everything, just a tiny validation. Please let me know what your thoughts are.
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement