fix: handle skipped condition dependencies in target gating - #8426
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates target gating so that condition dependencies must explicitly succeed (not be skipped) before a dependent target can run, addressing #7918.
Changes:
- Update shouldSkipResource to treat non-SUCCESS condition dependency results as blocking for AND gating.
- Add a TestRunTarget case for a target depending on multiple conditions to ensure it is skipped when prerequisites don’t succeed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/core/pipeline/utils.go | Tightens AND dependency gating for condition prerequisites to require explicit SUCCESS. |
| pkg/core/pipeline/targets_test.go | Adds a regression test to ensure a target is skipped when condition prerequisites don’t succeed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
|
@copilot apply changes based on the comments in this thread |
Sorry, something went wrong.
|
Thank you for the pullrequest, I'll try to review it soon |
Sorry, something went wrong.
olblak
left a comment
There was a problem hiding this comment.
Thank for the contribution
Sorry, something went wrong.
Signed-off-by: Olblak <me@olblak.com>
…b.com:nickzerjeski/updatecli into fix-conditional-target-dependson-skipped-7918
Fix #7918
Ensure AND dependency evaluation does not treat skipped conditions as successful prerequisites. A target depending on conditions should only run when those condition dependencies explicitly succeed.
Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement