fix(autodiscovery/flux): skip HelmRelease without chart template to avoid nil pointer panic - #8680
Merged
olblak merged 2 commits intoMay 10, 2026
Merged
fix(autodiscovery/flux): skip HelmRelease without chart template to avoid nil pointer panic#8680olblak merged 2 commits into
olblak merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
olblak
previously approved these changes
May 10, 2026
olblak
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you for the good catch
Sorry, something went wrong.
olblak
enabled auto-merge (squash)
May 10, 2026 07:43
Copy link
Copy Markdown
Member
|
@jouve Thank for the pull request, could you have a look to the failing test? |
Sorry, something went wrong.
…void nil pointer panic Fix updatecli#8679
auto-merge was automatically disabled
May 10, 2026 10:25
Head branch was pushed to by a user without write access
olblak
approved these changes
May 10, 2026
olblak
approved these changes
May 10, 2026
olblak
enabled auto-merge (squash)
May 10, 2026 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8679
Test
To test this pull request, you can run the following commands:
go test -test.fullpath=true -timeout 30s -run ^TestDiscoverManifests$ github.com/updatecli/updatecli/pkg/plugins/autodiscovery/fluxAdditional Information
Checklist
Tradeoff
Potential improvement