fix: sanitize version when checking the latest Updatecli version available - #8824
Merged
olblak merged 3 commits intoMay 16, 2026
Merged
fix: sanitize version when checking the latest Updatecli version available#8824olblak merged 3 commits into
olblak merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Olblak <me@olblak.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to normalize Updatecli version strings when checking whether the running binary is already at the latest published version.
Changes:
- Adds version sanitization to trim whitespace and remove a leading v.
- Updates the “new version available” log message to use sanitized version strings.
- Simplifies the versionHTTPEndpoint variable declaration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
pkg/core/engine/version.go
Outdated
Comment thread
pkg/core/engine/version.go
Outdated
Signed-off-by: Olblak <me@olblak.com>
olblak
enabled auto-merge (squash)
May 16, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix minor issue when checking the latest version as the one retrieved from updatecli.io contains a v prefix while the embedded in the binary doesn't
The goal is to avoid the following issue
Test
/
Additional Information
Checklist
Tradeoff
Potential improvement