I tested the pullrequest with the following example,

sources:
  default:
    kind: systemd
    spec:
      file: "/tmp/wg.container"
      section: "Container"
      option: Image

conditions:
  default:
    kind: systemd
    spec:
      file: "/tmp/wg.container"
      section: "Container"
      option: Image

targets:
  default:
    kind: systemd
    disablesourceinput: true
    spec:
      file: "/tmp/wg.container"
      section: "Container"
      option: Volume
      value: "xxx"

where /tmp/wg.container is the file mentioned in the issue.
One of things that I am wondering is how to handle multiple option like Volume or PublishPort

Another question that I am wondering in the case of the example shared in the linked issue.
Because right now it will update the first option it find

I tested the pullrequest with the following example,

sources:
  default:
    kind: systemd
    spec:
      file: "/tmp/wg.container"
      section: "Container"
      option: Image

conditions:
  default:
    kind: systemd
    spec:
      file: "/tmp/wg.container"
      section: "Container"
      option: Image

targets:
  default:
    kind: systemd
    disablesourceinput: true
    spec:
      file: "/tmp/wg.container"
      section: "Container"
      option: Volume
      value: "xxx"

where /tmp/wg.container is the file mentioned in the issue. One of things that I am wondering is how to handle multiple option like Volume or PublishPort

Another question that I am wondering in the case of the example shared in the linked issue. Because right now it will update the first option it find

Hmm, good point. I think a safer approach might be: update normally when there is only one match, but return an error when multiple matching options are found unless the user provides an explicit selector like index (would need to add that). If needed later, we could also add an explicit all: true, but I don’t think that should be the default

I tested the pullrequest with the following example,

sources:
  default:
    kind: systemd
    spec:
      file: "/tmp/wg.container"
      section: "Container"
      option: Image

conditions:
  default:
    kind: systemd
    spec:
      file: "/tmp/wg.container"
      section: "Container"
      option: Image

targets:
  default:
    kind: systemd
    disablesourceinput: true
    spec:
      file: "/tmp/wg.container"
      section: "Container"
      option: Volume
      value: "xxx"

where /tmp/wg.container is the file mentioned in the issue. One of things that I am wondering is how to handle multiple option like Volume or PublishPort
Another question that I am wondering in the case of the example shared in the linked issue. Because right now it will update the first option it find

Hmm, good point. I think a safer approach might be: update normally when there is only one match, but return an error when multiple matching options are found unless the user provides an explicit selector like index (would need to add that). If needed later, we could also add an explicit all: true, but I don’t think that should be the default

What do you think about this @olblak

sorry I missed the ball, to align the behavior with other plugins like the YAML one
I think the default should be to update only the first occurence unless an index value is defined

cfr documentindex in the yaml documentation

@ScMofeoluwa Do you need some help to finalize this pullrequest?

@ScMofeoluwa Do you need some help to finalize this pullrequest?

Sorry, this got buried in my mail. Thanks for the clarification. I’ll update the resource to follow that behavior and push an update shortly.

@olblak updated this now. I also addressed copilot's review but I left the target write path using go-systemd serialization for now rather than adding custom line/regex handling just to preserve comments, since that felt more fragile. Happy to adjust if you’d prefer a different approach

While doing some manual testing, I spotted a few issues that I fixed in my last commit.
On top of this I also implemented the default index which update all options if unset

I also forgot to specify in my comment, I removed the default value for section, and option as I think this plugin should be generic to any systemd configuration

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

I also forgot to specify in my comment, I removed the default value for section, and option as I think this plugin should be generic to any systemd configuration

Thanks for the fixes. The explicit section / option requirement makes sense for keeping this generic