fix: guard against short paths in changelog GitHub URL redirect - #9689
Closed
AruneshDwivedi wants to merge 1 commit into
Closed
fix: guard against short paths in changelog GitHub URL redirect#9689AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
redirectToGitHubRawContent indexed strings.Split(u.Path, "/")[3] without checking the slice length, so a github.com changelog URL with fewer than four path segments panicked with index out of range and aborted the whole run. Split once and only rewrite the segment when it exists, leaving short paths untouched. Added a unit test covering the short path and the tree->blob rewrite. Fixes updatecli#9688 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
Copy link
Copy Markdown
|
Tick the box to add this pull request to the merge queue (same as @mergifyio queue).
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redirectToGitHubRawContent indexed strings.Split(u.Path, "/")[3] without checking the slice length. A github.com changelog URL with fewer than four path segments (e.g. an annotation pointing at https://github.com/CHANGELOG.md) panicked with index out of range and aborted the whole run, since Changelog() calls it for every image advertising such an annotation.
Split once and only rewrite the segment when it exists, leaving short paths untouched. Added a unit test covering the short path and the tree->blob rewrite.
Fixes #9688