FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(github): use redirect.github.com for pull request links by Cremefreesh · Pull Request #9773 · updatecli/updatecli · GitHub

fix(github): use redirect.github.com for pull request links - #9773

Open
Cremefreesh wants to merge 1 commit into
updatecli:mainfrom
Cremefreesh:fix/redirect-github-pr-links
Open

fix(github): use redirect.github.com for pull request links#9773
Cremefreesh wants to merge 1 commit into
updatecli:mainfrom
Cremefreesh:fix/redirect-github-pr-links

Conversation

Copy link
Copy Markdown

Summary

Use redirect.github.com for GitHub pull request links in generated GitHub pull request bodies.

This keeps referenced pull requests clickable while preventing GitHub from creating noisy backlinks on those pull requests.

Changes

  • Added GitHub-specific pull request URL rewriting.
  • Applied the rewriting when creating and updating GitHub pull requests.
  • Left other GitHub URLs, including issue and release URLs, unchanged.
  • Added unit tests covering the URL rewriting behaviour.

Testing

go test ./pkg/core/reports ./pkg/plugins/scms/github

Copy link
Copy Markdown
Member

What's the resulting markdown? Can you add "before/after" to your PR body please?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL