FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Кулешова Ирина by trtz · Pull Request #24 · urfu-2016/javascript-task-3 · GitHub

/ javascript-task-3 Public

Кулешова Ирина - #24

Open
trtz wants to merge 4 commits into
urfu-2016:masterfrom
trtz:master
ConversationCommits (4)ChecksFiles changed
Open

Кулешова Ирина#24
trtz wants to merge 4 commits into
urfu-2016:masterfrom
trtz:master

Conversation

trtz commented Oct 23, 2016

Copy link
Copy Markdown

No description provided.

honest-hrundel commented Oct 23, 2016

Copy link
Copy Markdown

🍅 Пройдено тестов 10 из 19

honest-hrundel changed the title Ирина Кулешова Кулешова Ирина Oct 27, 2016

honest-hrundel commented Oct 27, 2016

Copy link
Copy Markdown

🍅 Пройдено тестов 13 из 19

honest-hrundel commented Oct 27, 2016

Copy link
Copy Markdown

🍅 Пройдено тестов 13 из 19

honest-hrundel commented Oct 27, 2016

Copy link
Copy Markdown

🍅 Пройдено тестов 11 из 16

mokhov requested changes Nov 10, 2016
View reviewed changes

mokhov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🍅

Comment thread robbery.js
if (lastSuccess === null) {
return '';
}
var hours = lastSuccess.hh < 10 ? '0' + lastSuccess.hh.toString() : lastSuccess.hh;

mokhov Nov 9, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Можно в отдельную функцию

Comment thread robbery.js
exports.isStar = false;

var days = {
ПН: 1,

mokhov Nov 9, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Почему не массивом?

Comment thread robbery.js
}

function convertToTargetTimeZoneDate(timeStamp) {
var day = Math.floor(Math.floor(timeStamp / 60) / 24);

mokhov Nov 9, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Здесь можно написать код функции оптимальнее

Comment thread robbery.js
};
}

function parseTime(strTime) {

mokhov Nov 10, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Здесь очень многое дублируется из parseDate

Comment thread robbery.js

function correlateWithBank(bankInterval) {
bankTimeZone = parseTime(bankInterval.from).timeZone;
var thursdayTimeStamp = getTimeStamp(4, bankTimeZone, 0);

mokhov Nov 10, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Почему четверг?

trtz commented Nov 10, 2016

Copy link
Copy Markdown
Author

Зачем проверять код задачи, которая даже не проходит тесты, если сегодня дедлайн по 4-й задаче, которая 4-й день висит непроверенной?

mokhov commented Nov 10, 2016 •
edited
Loading

Copy link
Copy Markdown

Зачем проверять код задачи, которая даже не проходит тесты, если сегодня дедлайн по 4-й задаче, которая 4-й день висит непроверенной?

Могу не проверять вообще

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mokhov mokhov requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL