Козлов Александр - #63
Conversation
Sorry, something went wrong.
|
🍏 Пройдено тестов 15 из 15 |
Sorry, something went wrong.
| var changedCollection = collection.map(function (el) { | ||
| return Object.assign({}, el); | ||
| }); | ||
| functions.sort(function (first, second) { |
There was a problem hiding this comment.
Для функции сортировки можно параметры называть a и b
Sorry, something went wrong.
| var fieldsToChoose = [].slice.call(arguments); | ||
|
|
||
| return function select(collection) { | ||
| return collection.map(function (el) { |
There was a problem hiding this comment.
el не несет никакой семантики, лучше подойдет название вроде person
Sorry, something went wrong.
|
|
||
| return function select(collection) { | ||
| return collection.map(function (el) { | ||
| return fieldsToChoose.reduce(function (newCollection, property) { |
There was a problem hiding this comment.
Первый аргумент назвал newCollection, но ведь это не коллеция, а объект с информацией о человеке
Sorry, something went wrong.
| console.info(property, values); | ||
|
|
||
| return; | ||
| return function filterIn(collection) { |
There was a problem hiding this comment.
Снова el никак не отражает того, что лежит внутри (в общем везде el нужно поменять)
Sorry, something went wrong.
|
|
||
| return; | ||
| return function sortBy(collection) { | ||
| var changedCollection = collection.sort(function (first, second) { |
There was a problem hiding this comment.
Зачем еще одну переменную создавать? Можно просто collection.sort()
Sorry, something went wrong.
| return function sortBy(collection) { | ||
| var changedCollection = collection.sort(function (first, second) { | ||
|
|
||
| return (first[property] > second[property]); |
There was a problem hiding this comment.
Функция сравнения должна возвращать 1 (если first > second по некоторому критерию), 0 (если равны) и -1 (если меньше)
Sorry, something went wrong.
|
🍅 |
Sorry, something went wrong.
No description provided.