tests/Cache/PoolTest.php (2)

41-52: Consider explicitly configuring retry settings for test clarity.

This test relies on the pool's default retry behavior to recover from the transient failure. Adding explicit configuration (like testPoolEmptyErrorIncludesDiagnostics does) would make the test's intent clearer and more resilient to upstream default changes.

♻️ Suggested improvement

         $pool = new UtopiaPool(new Stack(), 'retry-test', 2, function () use ($path, &$callCount) {
             $callCount++;
             if ($callCount === 1) {
                 throw new \Exception('Transient connection failure');
             }

             return new Filesystem($path);
         });
+        $pool->setRetryAttempts(2);
+        $pool->setRetrySleep(0);

         $cache = new Cache(new Pool($pool));

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Cache/PoolTest.php` around lines 41 - 52, The test currently relies on
UtopiaPool's implicit retry defaults to recover from the transient exception;
update the test to explicitly set retry configuration on the UtopiaPool
constructor (or on the Pool wrapper) so it's clear and robust—configure explicit
retry count/delay parameters (matching the style used in
testPoolEmptyErrorIncludesDiagnostics) for the UtopiaPool/Pool used to create
$cache so the first thrown Exception is retried deterministically; reference
UtopiaPool, Pool, Cache and the anonymous factory callback when making the
change.

---

36-39: Consider adding test directory cleanup.

The test directories (pool-retry, pool-diag) are created but not removed after tests complete. While not blocking, adding cleanup in a tearDownAfterClass or individual tearDown would prevent filesystem artifacts from accumulating.

Also applies to: 61-64

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Cache/PoolTest.php` around lines 36 - 39, Add cleanup to the test class
to remove the directories created during tests: implement a public static
function tearDownAfterClass() in the PoolTest class (or add a tearDown()
instance method if per-test cleanup is preferred) that checks for and
recursively removes the directories used in the diff (e.g.
__DIR__.'/tests/pool-retry' and __DIR__.'/tests/pool-diag'), using PHP functions
like is_dir(), glob()/scandir() and unlink()/rmdir() to delete files and
directories safely; ensure the cleanup runs regardless of test success and
guards against deleting unintended paths by building the target paths from
__DIR__ and verifying their names.

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@tests/Cache/PoolTest.php`:
- Around line 41-52: The test currently relies on UtopiaPool's implicit retry
defaults to recover from the transient exception; update the test to explicitly
set retry configuration on the UtopiaPool constructor (or on the Pool wrapper)
so it's clear and robust—configure explicit retry count/delay parameters
(matching the style used in testPoolEmptyErrorIncludesDiagnostics) for the
UtopiaPool/Pool used to create $cache so the first thrown Exception is retried
deterministically; reference UtopiaPool, Pool, Cache and the anonymous factory
callback when making the change.
- Around line 36-39: Add cleanup to the test class to remove the directories
created during tests: implement a public static function tearDownAfterClass() in
the PoolTest class (or add a tearDown() instance method if per-test cleanup is
preferred) that checks for and recursively removes the directories used in the
diff (e.g. __DIR__.'/tests/pool-retry' and __DIR__.'/tests/pool-diag'), using
PHP functions like is_dir(), glob()/scandir() and unlink()/rmdir() to delete
files and directories safely; ensure the cleanup runs regardless of test success
and guards against deleting unintended paths by building the target paths from
__DIR__ and verifying their names.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e8ecc7f1-bec9-400e-837c-cd89f73fae62

Reviewing files that changed from the base of the PR and between 7068870 and d2a23cf.

• composer.lock is excluded by !**/*.lock

• composer.json
• tests/Cache/PoolTest.php