numfmt: fix panic on multibyte locale decimal separator - #14167
Open
MadeNavaneeth wants to merge 1 commit into
Open
numfmt: fix panic on multibyte locale decimal separator#14167MadeNavaneeth wants to merge 1 commit into
MadeNavaneeth wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
GNU testsuite comparison: Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch) Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch) Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch) Congrats! The gnu test tests/seq/seq-epipe is now passing! |
Sorry, something went wrong.
MadeNavaneeth
force-pushed
the
fix/numfmt-multibyte-panic
branch
2 times, most recently
from
057d56a to
ac971d3
Compare
August 27, 2026 12:57
`find_valid_number_with_suffix` used `numeric_part.len()` (byte count) as a char count in `chars().skip()`, causing desync when the numeric part contains multibyte characters (e.g. Arabic `٫` separator). This led to slicing into a multibyte char boundary and panicking. Fixed by using `chars().count()` for char iteration and computing byte indices via `char_indices().nth()` for string slicing.
MadeNavaneeth
force-pushed
the
fix/numfmt-multibyte-panic
branch
from
ac971d3 to
5480866
Compare
August 27, 2026 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13937
What
numfmt panics with byte index N is not a char boundary when the input contains a multibyte locale decimal separator (e.g. Arabic ٫ U+066B in ar_SA.UTF-8) before a multibyte character and a suffix.
Root cause
find_valid_number_with_suffix used numeric_part.len() (byte length) as a char count in chars().skip(). When the numeric part contains multibyte characters, the byte count exceeds the char count, causing the char iterator to overshoot and the byte-slice index to land mid-character.
Fix
Testing