date: strip errno when write to stdout fails - #14206
Open
Devel08 wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
GNU testsuite comparison: Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch) Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch) |
Sorry, something went wrong.
xtqqczze
reviewed
Aug 28, 2026
Comment thread
src/uu/date/src/date.rs
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please use thiserror crate, something like:
#[derive(Debug, Error)]
enum DateError {
#[error("{}", translate!("date-error-write", "error" => strip_errno(.0)))]
Write(io::Error),
}
impl UError for DateError {}then use:
.map_err(DateError::Write)?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
sure, we can even wrap the other errors later too
Sorry, something went wrong.
Devel08
force-pushed
the
date-stdout-strip-errno
branch
from
d7217d8 to
07c4aa2
Compare
August 28, 2026 16:15
date: use thiserror update thiserror in fuzz
Devel08
force-pushed
the
date-stdout-strip-errno
branch
from
602d848 to
733e3f7
Compare
August 28, 2026 16:22
xtqqczze
reviewed
Aug 28, 2026
Comment thread
src/uu/date/Cargo.toml
Outdated
| ] | ||
|
|
||
| [dependencies] | ||
| thiserror = { workspace = true } |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: alphabetize
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.