xargs: reject quotes spanning input lines - #797
Open
wtcpython wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sylvestre
force-pushed
the
fix/xargs-reject-multiline-quotes
branch
from
12f27a8 to
37bf474
Compare
July 28, 2026 10:09
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 92.31% 92.25% -0.07%
==========================================
Files 35 35
Lines 7466 7471 +5
Branches 388 388
==========================================
Hits 6892 6892
- Misses 433 437 +4
- Partials 141 142 +1 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Merging this PR will not alter performance✅ 20 untouched benchmarks Comparing wtcpython:fix/xargs-reject-multiline-quotes (eeb7ead) with main (3de01a0) |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Commit 37bf474 has test result changes: bfs testsuite: Test results comparison: Current: TOTAL: 314 / PASSED: 266 / FAILED: 42 / SKIPPED: 6 Reference: TOTAL: 314 / PASSED: 267 / FAILED: 41 / SKIPPED: 6 Changes from main branch: TOTAL: +0 PASSED: -1 FAILED: +1 New test failures (1): - gnu/okdir_path_relative |
Sorry, something went wrong.
wtcpython
force-pushed
the
fix/xargs-reject-multiline-quotes
branch
from
37bf474 to
2d7ef17
Compare
August 11, 2026 01:09
sylvestre
force-pushed
the
fix/xargs-reject-multiline-quotes
branch
from
2d7ef17 to
c564172
Compare
August 18, 2026 17:21
Copy link
Copy Markdown
|
Commit c564172 has test result changes: bfs testsuite: Test results comparison: Current: TOTAL: 317 / PASSED: 274 / FAILED: 37 / SKIPPED: 6 Reference: TOTAL: 313 / PASSED: 267 / FAILED: 40 / SKIPPED: 6 Changes from main branch: TOTAL: +4 PASSED: +7 FAILED: -3 Test improvements (3): + gnu/execdir_path_dot + gnu/execdir_path_empty + gnu/execdir_path_relative |
Sorry, something went wrong.
sylvestre
force-pushed
the
fix/xargs-reject-multiline-quotes
branch
from
c564172 to
eeb7ead
Compare
August 26, 2026 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #776.
The whitespace-delimited argument reader allowed single and double quotes to span input lines. Quotes opened on one line could be closed on a later line, so malformed input was combined into arguments instead of rejected.
Reject a newline while a quote is open, matching GNU and BSD xargs behavior. Add regression coverage for both quote types when reading through --arg-file.