find: warn about useless -name/-wholename patterns - #812
Open
Xylphy wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #812 +/- ##
==========================================
+ Coverage 92.15% 92.19% +0.03%
==========================================
Files 35 35
Lines 7377 7401 +24
Branches 383 386 +3
==========================================
+ Hits 6798 6823 +25
+ Misses 438 435 -3
- Partials 141 143 +2 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Merging this PR will not alter performance✅ 20 untouched benchmarks Comparing Xylphy:fix/783-name-wholename-pattern-warnings (262d53e) with main (2a3eac9) |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Commit b757e1f has test result changes: bfs testsuite: Test results comparison: Current: TOTAL: 313 / PASSED: 267 / FAILED: 40 / SKIPPED: 6 Reference: TOTAL: 312 / PASSED: 266 / FAILED: 40 / SKIPPED: 6 Changes from main branch: TOTAL: +1 PASSED: +1 FAILED: +0 |
Sorry, something went wrong.
Emit non-fatal warnings at parse time for patterns that can never match,
matching GNU findutils behavior:
- Warn if a -name/-iname pattern contains a directory separator ('/'),
since these predicates match against basenames only.
- Warn if a -path/-wholename/-ipath/-iwholename pattern ends with '/',
since find never constructs paths with a trailing separator.
sylvestre
force-pushed
the
fix/783-name-wholename-pattern-warnings
branch
from
b757e1f to
262d53e
Compare
August 18, 2026 17:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #783
Summary
This PR implements GNU-compatible warnings for find patterns that can never match anything, addressing issue #783.
Previously, uutils find silently accepted patterns like -name /a.txt or -wholename foo/, which will never produce matches. GNU find emits non-fatal warnings to help users catch these common mistakes early.