find: reject the deprecated -perm +MODE octal form to match GNU - #851
Open
AlejandroCoronadoN wants to merge 1 commit into
Open
find: reject the deprecated -perm +MODE octal form to match GNU#851AlejandroCoronadoN wants to merge 1 commit into
AlejandroCoronadoN wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 35 35
Lines 7466 7471 +5
Branches 388 389 +1
=======================================
+ Hits 6892 6897 +5
Misses 433 433
Partials 141 141 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Merging this PR will not alter performance✅ 20 untouched benchmarks Comparing AlejandroCoronadoN:perm-plus-octal-reject (6dd8751) with main (d6ae4f9) |
Sorry, something went wrong.
sylvestre
force-pushed
the
perm-plus-octal-reject
branch
from
ac5998b to
6dd8751
Compare
August 27, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU find rejects the deprecated -perm +MODE octal form (a leading + followed by an octal number). uutils silently accepts it: the + is treated as an unknown prefix, so it falls through to an exact numeric comparison and matches files instead of erroring.
Same for +0 and +400. Symbolic forms (+rwx, +u+w) and the 644 / /644 / -644 forms are unaffected. This rejects a leading + followed by a digit, matching GNU.