Implement program wall - #492
Open
0jdxt wants to merge 8 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
|
cool, thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
sure, will squash them soon anyway and write a proper message |
Sorry, something went wrong.
Tries to mirror functionality with GNU, namely having timeout and nobanner options. TODO: - tests - buildable on windows
0jdxt
force-pushed
the
wall
branch
2 times, most recently
from
9ea3550 to
020172b
Compare
March 3, 2026 16:37
- added some argument tests. - used `cfg` directives to build on windows. - minor readability tweaks - infer/cast types for macos - satisfy clippy
- put deps in appropariate places
- use `uucore` methods to simplify code and remove a lot of manual
`unsafe { libc::...
0jdxt
marked this pull request as ready for review
March 5, 2026 18:31
- determine max hostname length from `libc::sysconf` - ensure buf is always nul terminated - check buf was actually written to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My initial working implementation.