fallocate: adds implementation - #512
Open
xfbs wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
implements allocate, collapse-range, dig-holes, insert-range, punch-holes, zero-range and posix_fallocate.
- Replace manual `bytes % threshold == 0` with `bytes.is_multiple_of(threshold)` - Gate Linux-only imports and helpers with `#[cfg(target_os = "linux")]` - Gate Linux-only tests with `#[cfg(target_os = "linux")]`
Copy link
Copy Markdown
Contributor
|
I have a fallocate implementation sitting around, too. Most of these tools are pretty simple. I think contributors would be ready to bang out tens of them if these PRs could get reviewed. @cakebaker @sylvestre |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements allocate, collapse-range, dig-holes, insert-range, punch-holes, zero-range and posix_fallocate.
this is my first contribution, please be kind :D
I've written some simple tests for it. What I have not tested is to see if the punch holes actually worked (I think i need to use fiemap for that, to get the raw extents.. can do that in the future, thought it wasn't worth it for now).