FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[lapack][rocSOLVER] Implement QR batch routines by zjin-lcf · Pull Request #781 · uxlfoundation/oneMath · GitHub

[lapack][rocSOLVER] Implement QR batch routines - #781

Open
zjin-lcf wants to merge 2 commits into
uxlfoundation:developfrom
zjin-lcf:feature/rocsolver-qr-batch
Open

zjin-lcf wants to merge 2 commits into
uxlfoundation:developfrom
zjin-lcf:feature/rocsolver-qr-batch

Conversation

Copy link
Copy Markdown
Contributor

Summary

  • implement strided and grouped geqrf_batch, orgqr_batch, and ungqr_batch for buffer and USM APIs
  • use rocSOLVER 64-bit batched geqrf entry points on rocSOLVER 3.26+, with a legacy fallback
  • preserve legacy APIs for orgqr/ungqr, which have no 64-bit rocSOLVER entry points
  • make grouped USM copy and cleanup dependencies explicit and add the corresponding scratchpad queries

Extracted from #767 for focused review. Depends on #778 for rocSOLVER version detection; until that PR merges, this branch intentionally includes its foundation commit.

Test plan

  • clang-format 19.1 check
  • git diff --check
  • rocSOLVER backend build for gfx90a
  • focused runtime tests on MI210 with ONEAPI_DEVICE_SELECTOR=hip:*: 40 passed
  • focused compile-time tests on MI210 with ONEAPI_DEVICE_SELECTOR=hip:*: 40 passed

The legacy pre-3.26 fallback is retained for compatibility; the local ROCm 7.1 installation exercises the 64-bit geqrf path.

zjin-lcf and others added 2 commits September 18, 2026 15:41
Add type-generic devInfo readers for legacy and 64-bit rocSOLVER entry points and report all failing matrices through lapack::batch_error.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
zjin-lcf requested a review from a team as a code owner September 18, 2026 23:10

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL