FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: (isMobilePhone) add Cyprus validation by ikerasiotis · Pull Request #1897 · validatorjs/validator.js · GitHub

feat: (isMobilePhone) add Cyprus validation - #1897

Merged
rubiin merged 2 commits into
validatorjs:masterfrom
ikerasiotis:master
Jul 19, 2022
Merged

feat: (isMobilePhone) add Cyprus validation#1897
rubiin merged 2 commits into
validatorjs:masterfrom
ikerasiotis:master

Conversation

Copy link
Copy Markdown
Contributor

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

codecov Bot commented Jan 19, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1897 (9cfd06a) into master (f055c11) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1897   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2072      2072           
  Branches       472       472           
=========================================
  Hits          2072      2072           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...9cfd06a. Read the comment docs.

profnandaa previously approved these changes Apr 22, 2022

profnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks for your contribution 🎉

// And sorry for the delay in reviewing this.

profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Apr 22, 2022

Copy link
Copy Markdown
Member

Just fix the m/c on README and we should be good to go.

rubiin merged commit 3873ebf into validatorjs:master Jul 19, 2022

rubiin commented Jul 19, 2022

Copy link
Copy Markdown
Member

Thankyou for the contribution 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mc-to-land Just merge-conflict standing between the PR and landing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL