FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add whitelist host to isEmail validation. by poor-cooder · Pull Request #1920 · validatorjs/validator.js · GitHub

/ validator.js Public

Add whitelist host to isEmail validation. - #1920

Merged
profnandaa merged 2 commits into
validatorjs:masterfrom
poor-cooder:feature/add-whitelist-host-to-isEmail
Oct 17, 2022
ConversationCommits (2)ChecksFiles changed
Merged

Add whitelist host to isEmail validation.#1920
profnandaa merged 2 commits into
validatorjs:masterfrom
poor-cooder:feature/add-whitelist-host-to-isEmail

Conversation

poor-cooder commented Jan 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add host whitelist to is Email validation.
closes: #1912

Add a new option (whitelist host) to isEmail options to check if the email domain is in it or not, if it was not in the whitelist host it fails.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

codecov Bot commented Jan 31, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1920 (6353545) into master (cfcf911) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1920   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2099    +2     
  Branches       473       474    +1     
=========================================
+ Hits          2097      2099    +2
Impacted Files Coverage Δ
src/lib/isEmail.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf911...6353545. Read the comment docs.

profnandaa approved these changes Apr 22, 2022
View reviewed changes

profnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks for your contrib 🎉

// And sorry for the delay in reviewing this.

profnandaa added 🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing. labels Apr 22, 2022

profnandaa commented Apr 22, 2022

Copy link
Copy Markdown
Member

Just fix the m/c on README and we should be good to go.

profnandaa mentioned this pull request Apr 22, 2022
Closed
3 tasks

poor-cooder commented Apr 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Just fix the m/c on README and we should be good to go.

Hi, Thank you. The conflict has been fixed! 🚀

SpiffGreen commented Jul 30, 2022

Copy link
Copy Markdown

Can this be merged and closed now?

rubiin added ready-to-land For PRs that are reviewed and ready to be landed ✅ LGTM and removed mc-to-land Just merge-conflict standing between the PR and landing. labels Jul 31, 2022
profnandaa merged commit c1d1b48 into validatorjs:master Oct 17, 2022
profnandaa mentioned this pull request Feb 2, 2023
Closed
rntvicente mentioned this pull request May 24, 2024
Open
sahilpawar58 mentioned this pull request May 25, 2024
Open
ChinmoyHembram mentioned this pull request May 25, 2024
Open
wambugucoder mentioned this pull request May 30, 2024
Open
rntvicente mentioned this pull request May 30, 2024
Open
DefenderK mentioned this pull request May 30, 2024
Closed
ChinmoyHembram mentioned this pull request May 30, 2024
Open
ceconcarlsen mentioned this pull request May 31, 2024
Open
sumandas0 mentioned this pull request May 31, 2024
Open
This was referenced Jun 3, 2024
Closed
Closed
DefenderK mentioned this pull request Jun 7, 2024
Closed
IT21275210 mentioned this pull request Jun 8, 2024
Open
snyk-io Bot mentioned this pull request Jun 10, 2024
Closed
florinMiro mentioned this pull request Jun 11, 2024
Closed
snyk-io Bot mentioned this pull request Jun 11, 2024
Closed
This was referenced Jun 12, 2024
Closed
Closed
snyk-io Bot mentioned this pull request Jun 13, 2024
Closed
DefenderK mentioned this pull request Jun 13, 2024
Closed
This was referenced Jun 14, 2024
Closed
Closed
DefenderK mentioned this pull request Jun 14, 2024
Closed
This was referenced Jun 20, 2024
Closed
Closed
snyk-io Bot mentioned this pull request Jun 28, 2024
Closed
This was referenced Jul 10, 2024
Closed
Closed
Closed
rm-neilsondesa mentioned this pull request Jul 16, 2024
Open
snyk-io Bot mentioned this pull request Jul 18, 2024
Closed
DefenderK mentioned this pull request Jul 18, 2024
Closed
This was referenced Jul 19, 2024
Closed
Closed
Closed
luizhp mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 30, 2024
Open
Open
sumandas0 mentioned this pull request Sep 8, 2024
Open
TheJ-Erk400 mentioned this pull request Sep 8, 2024
Open
Bastien-Durand mentioned this pull request Sep 9, 2024
Open
KOTTAGENVH mentioned this pull request Sep 27, 2024
Open
DefenderK mentioned this pull request Oct 30, 2024
Closed
fossabot Bot mentioned this pull request Oct 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

profnandaa profnandaa approved these changes

Assignees

No one assigned

Labels

🎉 first-pr ✅ LGTM ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

isEmail add host_whitelist option

4 participants

Back | FazBrowse Home | New Git URL