FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added isMobilePhone valid regex for 3 countries by Mustafiz04 · Pull Request #1925 · validatorjs/validator.js · GitHub

/ validator.js Public

Added isMobilePhone valid regex for 3 countries - #1925

Merged
rubiin merged 2 commits into
validatorjs:masterfrom
Mustafiz04:feature/all-country-regex
Jul 19, 2022
ConversationCommits (2)ChecksFiles changed
Merged

Added isMobilePhone valid regex for 3 countries#1925
rubiin merged 2 commits into
validatorjs:masterfrom
Mustafiz04:feature/all-country-regex

Conversation

Mustafiz04 commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

I have added valid regex for Afghanistan, Yemen and Western Sahara.
I will add more regex for missing countries mainly Caribbean and small Island.
Solved and added test for issue #1761

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

codecov Bot commented Feb 5, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1925 (fba9680) into master (c193fe5) will not change coverage.
The diff coverage is n/a.

❗ Current head fba9680 differs from pull request most recent head afdbd68. Consider uploading reports for the commit afdbd68 to get more accurate results

@@            Coverage Diff            @@
##            master     #1925   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       102    -2     
  Lines         2120      2072   -48     
  Branches       475       472    -3     
=========================================
- Hits          2120      2072   -48
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/index.js 100.00% <0.00%> (ø)
src/lib/isIP.js 100.00% <0.00%> (ø)
src/lib/alpha.js 100.00% <0.00%> (ø)
src/lib/isURL.js 100.00% <0.00%> (ø)
src/lib/isTaxID.js 100.00% <0.00%> (ø)
src/lib/isBase32.js 100.00% <0.00%> (ø)
src/lib/isLength.js 100.00% <0.00%> (ø)
src/lib/isMagnetURI.js 100.00% <0.00%> (ø)
src/lib/isCreditCard.js 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c193fe5...afdbd68. Read the comment docs.

Mustafiz04 commented Feb 5, 2022

Copy link
Copy Markdown
Contributor Author

@ezkemboi can you please review this PR ?

I apologise for being a little late for this PR because I was busy at work.
Could you please provide a place where I can learn regex because I'm having trouble developing regex for the Caribbean and tiny islands?

rubiin approved these changes Feb 14, 2022
View reviewed changes

rubiin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good

rubiin previously approved these changes Feb 14, 2022
View reviewed changes
rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jul 18, 2022
rubiin merged commit 89949e7 into validatorjs:master Jul 19, 2022

rubiin commented Jul 19, 2022

Copy link
Copy Markdown
Member

Thankyou for the contribution 🎉

profnandaa mentioned this pull request Feb 2, 2023
Closed
rntvicente mentioned this pull request May 24, 2024
Open
sahilpawar58 mentioned this pull request May 25, 2024
Open
ChinmoyHembram mentioned this pull request May 25, 2024
Open
fossabot Bot mentioned this pull request Oct 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rubiin rubiin approved these changes

Assignees

No one assigned

Labels

mc-to-land Just merge-conflict standing between the PR and landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL