FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(isMobilePhone): Added regex for Aruba nl-AW by adida948 · Pull Request #1985 · validatorjs/validator.js · GitHub

/ validator.js Public

feat(isMobilePhone): Added regex for Aruba nl-AW - #1985

Merged
profnandaa merged 3 commits into
validatorjs:masterfrom
adida948:main
Jul 3, 2022
ConversationCommits (3)ChecksFiles changed
Merged

feat(isMobilePhone): Added regex for Aruba nl-AW#1985
profnandaa merged 3 commits into
validatorjs:masterfrom
adida948:main

Conversation

adida948 commented Jun 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added validation for Aruba on isMobilePhone.
referred issue: #1761

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

codecov Bot commented Jun 13, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1985 (8eef656) into master (37cbd5c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1985   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2099      2099           
  Branches       474       474           
=========================================
  Hits          2099      2099
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cbd5c...8eef656. Read the comment docs.

rubiin previously approved these changes Jun 21, 2022
View reviewed changes

rubiin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM @profnandaa

tux-tn previously approved these changes Jun 24, 2022
View reviewed changes

tux-tn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 🎉
Thank you for your PR @adida948

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Jun 24, 2022

profnandaa commented Jun 30, 2022

Copy link
Copy Markdown
Member

@rubiin -- you'd an invite to join the org, let me resend. Thanks for your review on this too!

profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Jun 30, 2022
profnandaa previously approved these changes Jun 30, 2022
View reviewed changes

profnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, just the m/c which I'll fix on a bulk PR before release.

adida948 dismissed stale reviews from profnandaa, tux-tn, and rubiin via b1433b9 July 1, 2022 16:16

adida948 commented Jul 1, 2022

Copy link
Copy Markdown
Contributor Author

HI, let me know if there is anything else needed from my side.

adida948 requested review from profnandaa, rubiin and tux-tn July 1, 2022 16:23
rubiin requested changes Jul 1, 2022
View reviewed changes

rubiin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

On Readme there is still the merge markers. please remove that

adida948 commented Jul 1, 2022

Copy link
Copy Markdown
Contributor Author

@rubiin tried the github UI. I messed up the update. Did it from command line now.
thanks. I have removed them

adida948 requested a review from rubiin July 1, 2022 17:46
profnandaa merged commit 6fb8bb5 into validatorjs:master Jul 3, 2022
profnandaa mentioned this pull request Feb 2, 2023
Closed
rntvicente mentioned this pull request May 24, 2024
Open
sahilpawar58 mentioned this pull request May 25, 2024
Open
ChinmoyHembram mentioned this pull request May 25, 2024
Open
fossabot Bot mentioned this pull request Oct 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

profnandaa profnandaa approved these changes
rubiin rubiin approved these changes
tux-tn Awaiting requested review from tux-tn

Assignees

No one assigned

Labels

🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL