FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Feat/jamaica addition by ademyan05 · Pull Request #1986 · validatorjs/validator.js · GitHub

/ validator.js Public

Feat/jamaica addition - #1986

Merged
rubiin merged 3 commits into
validatorjs:masterfrom
ademyan05:feat/Jamaica-addition
Jul 19, 2022
ConversationCommits (3)ChecksFiles changed
Merged

Feat/jamaica addition#1986
rubiin merged 3 commits into
validatorjs:masterfrom
ademyan05:feat/Jamaica-addition

Conversation

ademyan05 commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

added Jamaica's locale into isMobilePhone.js

rubiin previously approved these changes Jun 21, 2022
View reviewed changes

codecov Bot commented Jun 24, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@7832d4a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7786bb3 differs from pull request most recent head 35fc280. Consider uploading reports for the commit 35fc280 to get more accurate results

@@            Coverage Diff             @@
##             master     #1986   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?       103           
  Lines             ?      2097           
  Branches          ?       473           
==========================================
  Hits              ?      2097           
  Misses            ?         0           
  Partials          ?         0
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7832d4a...35fc280. Read the comment docs.

rubiin commented Jul 17, 2022

Copy link
Copy Markdown
Member

@ademyan05 can you fix the conflict

rubiin merged commit 450a2c0 into validatorjs:master Jul 19, 2022

rubiin commented Jul 19, 2022

Copy link
Copy Markdown
Member

Thankyou for the contribution 🎉

rieg-ec commented Dec 16, 2022 •
edited
Loading

Copy link
Copy Markdown

it seems like this deleted the fix for Honduras phone numbers by mistake 😢

WikiRik mentioned this pull request Dec 17, 2022
Merged
3 tasks
profnandaa pushed a commit that referenced this pull request Jan 22, 2023
fix(isMobilePhone): re-add es-HN fix from #1983 (#2129)
d8f3a24 
The fix was accidentally removed in #1986
profnandaa mentioned this pull request Feb 2, 2023
Closed
rntvicente mentioned this pull request May 24, 2024
Open
sahilpawar58 mentioned this pull request May 25, 2024
Open
ChinmoyHembram mentioned this pull request May 25, 2024
Open
fossabot Bot mentioned this pull request Oct 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rubiin rubiin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL