FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix/readme.md by ademyan05 · Pull Request #1987 · validatorjs/validator.js · GitHub

/ validator.js Public

Fix/readme.md - #1987

Closed
ademyan05 wants to merge 4 commits into
validatorjs:masterfrom
ademyan05:fix/Readme.md
ConversationCommits (4)ChecksFiles changed
Closed

Fix/readme.md#1987
ademyan05 wants to merge 4 commits into
validatorjs:masterfrom
ademyan05:fix/Readme.md

Conversation

ademyan05 commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

fixed the syntax of arrays in the Readme, as some were missing commas and single quotations.

rubiin approved these changes Jun 21, 2022
View reviewed changes

rubiin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM @profnandaa

codecov Bot commented Jun 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1987 (8b564ae) into master (cfcf911) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1987   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2097           
  Branches       473       473           
=========================================
  Hits          2097      2097

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf911...8b564ae. Read the comment docs.

tux-tn approved these changes Jun 24, 2022
View reviewed changes

tux-tn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM ! Thank you @ademyan05

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Jun 24, 2022
profnandaa approved these changes Jun 30, 2022
View reviewed changes

profnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Really keen eye! Thanks for the fix 🎉

profnandaa commented Jun 30, 2022

Copy link
Copy Markdown
Member

@ademyan05 -- can fix the m/c or I can do it in a bulk PR too.

profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Jun 30, 2022

rubiin commented Jul 27, 2022

Copy link
Copy Markdown
Member

@ademyan05 MR needs fixing

pano9000 commented Dec 29, 2022

Copy link
Copy Markdown
Contributor

FYI:
I have incorporated the same changes (+ additional fixes) from this PR in my PR as well:
#2107

626bcae

WikiRik commented Jan 30, 2023

Copy link
Copy Markdown
Member

@pano9000 I assume we can close this now #2107 has been merged?

pano9000 commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

closing the PR as its changes were merged as part of the bigger #2107 / 0586d23
@WikiRik thanks for reminding me
@ademyan05 thank you for the PR and sorry for having to close this one!

pano9000 closed this Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

profnandaa profnandaa approved these changes
tux-tn tux-tn approved these changes
rubiin rubiin approved these changes

Assignees

No one assigned

Labels

🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL