FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Feature/add country benin by rksp25 · Pull Request #1997 · validatorjs/validator.js · GitHub

/ validator.js Public

Feature/add country benin - #1997

Merged
rubiin merged 6 commits into
validatorjs:masterfrom
rksp25:feature/add-country-benin
Jul 18, 2022
ConversationCommits (6)ChecksFiles changed
Merged

Feature/add country benin#1997
rubiin merged 6 commits into
validatorjs:masterfrom
rksp25:feature/add-country-benin

Conversation

rksp25 commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

Added regex for Benin fr-BJ

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

rksp25 mentioned this pull request Jul 5, 2022
Open
rksp25 mentioned this pull request Jul 5, 2022
Merged
3 tasks

rksp25 commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

@profnandaa Can you please review this PR!!

rubiin requested changes Jul 17, 2022
View reviewed changes

rubiin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like you have to fix merge conflicts before we can merge

codecov Bot commented Jul 17, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1997 (625603d) into master (518a663) will not change coverage.
The diff coverage is n/a.

❗ Current head 625603d differs from pull request most recent head 4096915. Consider uploading reports for the commit 4096915 to get more accurate results

@@            Coverage Diff            @@
##            master     #1997   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2120      2108   -12     
  Branches       475       475           
=========================================
- Hits          2120      2108   -12
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/lib/isIP.js 100.00% <0.00%> (ø)
src/lib/isLength.js 100.00% <0.00%> (ø)
src/lib/isLicensePlate.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 518a663...4096915. Read the comment docs.

rksp25 commented Jul 17, 2022

Copy link
Copy Markdown
Contributor Author

@rubiin conflict fixed please review

rksp25 commented Jul 17, 2022

Copy link
Copy Markdown
Contributor Author

Looks like you have to fix merge conflicts before we can merge

@rubiin conflict fixed please review

rksp25 requested a review from rubiin July 17, 2022 19:58
rubiin previously approved these changes Jul 18, 2022
View reviewed changes
rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jul 18, 2022

rubiin commented Jul 18, 2022

Copy link
Copy Markdown
Member

@rksp25 still says conflict. Rest is ok

rubiin merged commit a17421a into validatorjs:master Jul 18, 2022

rubiin commented Jul 18, 2022

Copy link
Copy Markdown
Member

Thankyou for the contribution 🎉

profnandaa mentioned this pull request Feb 2, 2023
Closed
rntvicente mentioned this pull request May 24, 2024
Open
sahilpawar58 mentioned this pull request May 25, 2024
Open
ChinmoyHembram mentioned this pull request May 25, 2024
Open
fossabot Bot mentioned this pull request Oct 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rubiin rubiin approved these changes

Assignees

No one assigned

Labels

mc-to-land Just merge-conflict standing between the PR and landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL