FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(isLicensePlate): add es-AR license plate validator by alvarocastro · Pull Request #2103 · validatorjs/validator.js · GitHub

/ validator.js Public

feat(isLicensePlate): add es-AR license plate validator - #2103

Closed
alvarocastro wants to merge 1 commit into
validatorjs:masterfrom
alvarocastro:master
ConversationCommits (1)ChecksFiles changed
Closed

feat(isLicensePlate): add es-AR license plate validator#2103
alvarocastro wants to merge 1 commit into
validatorjs:masterfrom
alvarocastro:master

Conversation

alvarocastro commented Nov 20, 2022 •
edited
Loading

Copy link
Copy Markdown

Added validation regex for Argentina license plates whose format can be AB 123 CD or ABC 123.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

codecov Bot commented Nov 20, 2022

Copy link
Copy Markdown

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3476598) compared to base (531dc7f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #2103   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2309    +1     
  Branches       578       578           
=========================================
+ Hits          2308      2309    +1
Impacted Files Coverage Δ
src/lib/isLicensePlate.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

WikiRik reviewed Dec 13, 2022
View reviewed changes

WikiRik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do you have a source on this?

alvarocastro commented Dec 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

Do you have a source on this?

I live in Argentina, couldn't find any "official" source, but here is a wikipedia article: https://en.wikipedia.org/wiki/Vehicle_registration_plates_of_Argentina

This validator supports:

  • The old format "ABC 123" (specific for Argentina) that it's still valid but not issued anymore and;
  • The new format "AB 123 CD" which is the current Argentine standard (actually is the standard for all the Mercosur countries).

rubiin added ✅ LGTM and removed ✅ LGTM labels Jan 23, 2023
rubiin requested a review from WikiRik January 23, 2023 07:08
profnandaa approved these changes Jan 29, 2023
View reviewed changes

profnandaa left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks for your PR. I'll fix the merge conflict in the release.

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM labels Jan 29, 2023
profnandaa added a commit that referenced this pull request Jan 31, 2023
feat(isLicensePlate): add es-AR locale (#2169)
a310168 
Co-authored-by: Alvaro Castro <moltar89@gmail.com>

@profnandaa: clean up #2103

profnandaa commented Jan 31, 2023

Copy link
Copy Markdown
Member

combined in #2164

profnandaa closed this Jan 31, 2023
profnandaa mentioned this pull request Feb 2, 2023
Closed
rntvicente mentioned this pull request May 24, 2024
Open
sahilpawar58 mentioned this pull request May 25, 2024
Open
ChinmoyHembram mentioned this pull request May 25, 2024
Open
fossabot Bot mentioned this pull request Oct 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

profnandaa profnandaa approved these changes
WikiRik WikiRik approved these changes

Assignees

No one assigned

Labels

🎉 first-pr ✅ LGTM mc-to-land Just merge-conflict standing between the PR and landing. PR/combined

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL