Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4350655) compared to base (531dc7f).
Patch coverage: 100.00% of modified lines in pull request are covered.

@@            Coverage Diff            @@
##            master     #2142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2328   +20     
  Branches       578       584    +6     
=========================================
+ Hits          2308      2328   +20     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kind of overlooked this, but question here is the same regarding the usage of
str = str.trim();

should sanitizing the string really be part of the validator? I would say "no".
see also my explanation here:
#2143

Apologies for not noticing this point. Actually, I share the same thought with you: this validator should only take care about the validation part. However, I noticed other contributors in isIdentityCard.js all wrote codes to sanitize the incoming string:

const sanitized = str.trim().toUpperCase();

const sanitized = str.trim();

To make my codes consistent with others, I believe it is better to keep the sanitization before validation.