fix(isMobilePhone): fix 'ms-MY' matching invalid numbers - #2155
Merged
profnandaa merged 1 commit intoJan 29, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍 Additional details and impacted files @@ Coverage Diff @@
## master #2155 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2335 2335
Branches 586 586
=========================================
Hits 2335 2335
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sorry, something went wrong.
WikiRik
previously approved these changes
Jan 23, 2023
Santhosh-Kumar-99
previously approved these changes
Jan 24, 2023
rubiin
previously approved these changes
Jan 24, 2023
refactored the regexp:
---
* removed meaningless {1} quantifiers
* simplified regexp a bit (removing useless escape character)
* fixed the bug that would cause it to match invalid numbers
tests
---
* added tests for invalid numbers
fixes validatorjs#1066
pano9000
dismissed stale reviews from rubiin, Santhosh-Kumar-99, and WikiRik
via
a260c5f
January 28, 2023 23:14
pano9000
force-pushed
the
fix_isMobilePhone_#1066
branch
from
e3bd52d to
a260c5f
Compare
January 28, 2023 23:14
WikiRik
approved these changes
Jan 28, 2023
rubiin
approved these changes
Jan 29, 2023
profnandaa
approved these changes
Jan 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactoredthe regexp:
and most importantly:
tests
fixes #1066