FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(isMobilePhone): Add regex for Somalia so-SO by ohersi · Pull Request #2175 · validatorjs/validator.js · GitHub

/ validator.js Public

feat(isMobilePhone): Add regex for Somalia so-SO - #2175

Merged
profnandaa merged 4 commits into
validatorjs:masterfrom
ohersi:add-country-somalia
Feb 8, 2023
ConversationCommits (4)ChecksFiles changed
Merged

feat(isMobilePhone): Add regex for Somalia so-SO#2175
profnandaa merged 4 commits into
validatorjs:masterfrom
ohersi:add-country-somalia

Conversation

ohersi commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Added regex validation for Somalia (so-SO) mobile phone numbers, country codes referenced from these documents:

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

profnandaa reviewed Feb 2, 2023
View reviewed changes

profnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This LGTM, we're just about to make our next release and the preps are done. Unfortunately this will miss the train but should be on the next one.

Please fix the merge conflicts.

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM 🎉 first-pr labels Feb 2, 2023
ezkemboi previously approved these changes Feb 6, 2023
View reviewed changes

ezkemboi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.
Please check @rubiin @profnandaa @tux-tn

ezkemboi reviewed Feb 7, 2023
View reviewed changes
Comment thread test/validators.test.js Outdated
ezkemboi reviewed Feb 7, 2023
View reviewed changes
Comment thread test/validators.test.js Outdated

codecov Bot commented Feb 7, 2023

Copy link
Copy Markdown

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f89e0a8) compared to base (54d330c).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #2175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2324      2324           
  Branches       586       586           
=========================================
  Hits          2324      2324
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ezkemboi added the ready-to-land For PRs that are reviewed and ready to be landed label Feb 7, 2023
profnandaa merged commit ecce35f into validatorjs:master Feb 8, 2023
profnandaa mentioned this pull request Aug 3, 2023
Closed
rntvicente mentioned this pull request May 24, 2024
Open
sahilpawar58 mentioned this pull request May 25, 2024
Open
ChinmoyHembram mentioned this pull request May 25, 2024
Open
kaifkh20 mentioned this pull request May 30, 2024
Open
Safar123 mentioned this pull request May 30, 2024
Open
IT21149412 mentioned this pull request May 30, 2024
Open
Achmad-Farid mentioned this pull request May 30, 2024
Open
ahmetilboga2004 mentioned this pull request May 30, 2024
Merged
wambugucoder mentioned this pull request May 30, 2024
Open
TuanNB28 mentioned this pull request May 30, 2024
Open
StemmlerSisters mentioned this pull request May 30, 2024
Open
snyk-io Bot mentioned this pull request Jul 18, 2024
Closed
DefenderK mentioned this pull request Jul 18, 2024
Closed
This was referenced Jul 19, 2024
Closed
Closed
Closed
vky5 mentioned this pull request Jul 30, 2024
Closed
Playgirlkaybraz11 mentioned this pull request Aug 12, 2024
Open
luizhp mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 30, 2024
Open
Open
TheJ-Erk400 mentioned this pull request Sep 7, 2024
Open
sumandas0 mentioned this pull request Sep 8, 2024
Open
TheJ-Erk400 mentioned this pull request Sep 8, 2024
Open
Bastien-Durand mentioned this pull request Sep 9, 2024
Open
kaifkh20 mentioned this pull request Sep 9, 2024
Merged
This was referenced Sep 10, 2024
Open
Open
harish845 mentioned this pull request Sep 13, 2024
Open
MohammadGhajari mentioned this pull request Sep 14, 2024
Open
harish845 mentioned this pull request Sep 14, 2024
Open
vky5 mentioned this pull request Sep 15, 2024
Closed
amay0808 mentioned this pull request Sep 16, 2024
Open
IT21269134 mentioned this pull request Sep 17, 2024
Open
MohammadGhajari mentioned this pull request Sep 18, 2024
Open
ch4mi2 mentioned this pull request Sep 19, 2024
Closed
MohammadGhajari mentioned this pull request Sep 19, 2024
Open
pasanchamikara99 mentioned this pull request Sep 26, 2024
Open
KOTTAGENVH mentioned this pull request Sep 27, 2024
Open
DefenderK mentioned this pull request Oct 30, 2024
Closed
fossabot Bot mentioned this pull request Oct 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

profnandaa profnandaa approved these changes
rubiin rubiin approved these changes
ezkemboi ezkemboi approved these changes

Assignees

No one assigned

Labels

🎉 first-pr ✅ LGTM mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL