FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(isEmail): Disallow emails starting with but not ending with quote by sciffany · Pull Request #2185 · validatorjs/validator.js · GitHub

/ validator.js Public

feat(isEmail): Disallow emails starting with but not ending with quote - #2185

Closed
sciffany wants to merge 1 commit into
validatorjs:masterfrom
sciffany:master
ConversationCommits (1)ChecksFiles changed
Closed

feat(isEmail): Disallow emails starting with but not ending with quote#2185
sciffany wants to merge 1 commit into
validatorjs:masterfrom
sciffany:master

Conversation

sciffany commented Feb 18, 2023 •
edited
Loading

Copy link
Copy Markdown

I have invalidated all emails where the user part begins with a quotation but does not end with a quotation. Solves #2184

For example, these are invalid emails:
"example@email.com
"<example@email.com
" example@email.com

Reference:
"spaces, quotes, and backslashes may only exist when within quoted strings and preceded by a backslash" ~https://en.wikipedia.org/wiki/Email_address#Examples

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

sciffany changed the title Disallow emails starting with quote feat(isEmail): Disallow emails starting with quote Feb 18, 2023

codecov Bot commented Feb 18, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (43803c0) to head (03d1a2a).
Report is 104 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #2185   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         2348      2348           
  Branches       593       593           
=========================================
  Hits          2348      2348

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sciffany changed the title feat(isEmail): Disallow emails starting with quote feat(isEmail): Disallow emails starting with but not ending with quote Feb 18, 2023
Ahmad-RW approved these changes Feb 24, 2023
View reviewed changes

Ahmad-RW left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍🏼

WikiRik approved these changes Mar 10, 2023
View reviewed changes

WikiRik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We already have tests in the valid section for this, so looks good to me!

sciffany commented Mar 26, 2023

Copy link
Copy Markdown
Author

Hi, why is merging still blocked after two approving reviews. Thanks!

WikiRik commented Mar 26, 2023

Copy link
Copy Markdown
Member

Hi, why is merging still blocked after two approving reviews. Thanks!

You need two approving reviews of people with merge rights, which does not include us

feeedback commented May 11, 2023

Copy link
Copy Markdown

any news?

WikiRik requested a review from rubiin March 28, 2025 20:58

WikiRik commented Mar 28, 2025

Copy link
Copy Markdown
Member

This has been resolved in #2437

WikiRik closed this Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

WikiRik WikiRik approved these changes
rubiin Awaiting requested review from rubiin
+1 more reviewer
Ahmad-RW Ahmad-RW approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL