FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added support for PK(Pakistan) in isIdentityCard by Daniyal-Qureshi · Pull Request #2291 · validatorjs/validator.js · GitHub

/ validator.js Public

Added support for PK(Pakistan) in isIdentityCard - #2291

Merged
profnandaa merged 3 commits into
validatorjs:masterfrom
Daniyal-Qureshi:pakistani_identity_card_support
Jun 4, 2024
ConversationCommits (3)ChecksFiles changed
Merged

Added support for PK(Pakistan) in isIdentityCard #2291
profnandaa merged 3 commits into
validatorjs:masterfrom
Daniyal-Qureshi:pakistani_identity_card_support

Conversation

Daniyal-Qureshi commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

Add a regex pattern for validating valid Pakistani Computerized National Identity Cards (CNICs):

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

codecov Bot commented Sep 27, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (b958bd7) to head (e46885f).
Report is 33 commits behind head on master.

❗ Current head e46885f differs from pull request most recent head 622e39c

Please upload reports for the commit 622e39c to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2291      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2453       -1     
  Branches      619      619              
==========================================
- Hits         2453     2452       -1     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WikiRik reviewed Sep 28, 2023
View reviewed changes

WikiRik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please use 'PK' as locale instead of 'ur-PK'
What's the source for the regex?

Daniyal-Qureshi commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

@WikiRik
I've adopted a convention familiar to many developers, using the initial of the national language followed by the initial of the country name. Please Check out the source behind this intriguing regex pattern: CNIC regex format

Daniyal-Qureshi commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

@WikiRik Hi is there any other fixes needed here.

rubiin requested a review from WikiRik May 30, 2024 17:34

rubiin commented May 30, 2024

Copy link
Copy Markdown
Member

@Daniyal-Qureshi could you also mention the source ?

rubiin added the 🧹 needs-update For PRs that need to be updated before landing label Jun 1, 2024

Daniyal-Qureshi commented Jun 2, 2024

Copy link
Copy Markdown
Contributor Author

Hi @rubiin I have used following sources.

rubiin requested changes Jun 2, 2024
View reviewed changes

rubiin left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ur-PK you could simply do as PK as suggested by @WikiRik
rest looks good for merge imo

Daniyal-Qureshi commented Jun 2, 2024

Copy link
Copy Markdown
Contributor Author

@rubiin I have changed the local from ur-PK to PK, please review.

rubiin added 🧹 needs-update For PRs that need to be updated before landing ✅ LGTM and removed 🧹 needs-update For PRs that need to be updated before landing labels Jun 2, 2024
rubiin requested a review from profnandaa June 2, 2024 11:18
Daniyal-Qureshi changed the title Added support for ur-PK(Pakistan) in isIdentityCard Added support for PK(Pakistan) in isIdentityCard Jun 2, 2024
profnandaa approved these changes Jun 4, 2024
View reviewed changes

profnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks for your contrib! 🎉

profnandaa merged commit 08257b5 into validatorjs:master Jun 4, 2024
WikiRik mentioned this pull request Mar 20, 2025
Merged
fossabot Bot mentioned this pull request Oct 28, 2025
Closed
superfortune-passion pushed a commit to superfortune-passion/validator.js that referenced this pull request May 31, 2026
feat(isIdentityCard): add support for PK(Pakistan) (validatorjs#2291)
f8bd3d3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

profnandaa profnandaa approved these changes
rubiin rubiin approved these changes
WikiRik Awaiting requested review from WikiRik

Assignees

No one assigned

Labels

✅ LGTM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL