chore: Modernize sample app - #104
Conversation
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Angular demo application by removing polyfills, updating to zoneless change detection, converting to modern Angular template syntax, and implementing new input patterns.
- Removes polyfills.ts file and references as they're no longer needed in modern Angular
- Converts templates from *ngIf and *ngFor to new @if and @for control flow syntax
- Updates components to use ChangeDetectionStrategy.OnPush and zoneless change detection
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| projects/demo/tsconfig.spec.json | Removes polyfills.ts reference from test configuration |
| projects/demo/tsconfig.app.json | Removes polyfills.ts reference from app configuration |
| projects/demo/src/polyfills.ts | Deletes entire polyfills file |
| projects/demo/src/main.ts | Adds zoneless change detection provider |
| projects/demo/src/app/joi-example/joi-example.component.html | Converts *ngIf to @if control flow |
| projects/demo/src/app/home.component.ts | Removes unused CommonModule import |
| projects/demo/src/app/form3/form3.component.ts | Adds OnPush change detection strategy |
| projects/demo/src/app/form3/form3.component.html | Converts control flow syntax and removes empty line |
| projects/demo/src/app/form3/form3-tags/form3-tags.component.ts | Converts @input to input() signals and adds OnPush |
| projects/demo/src/app/form3/contacts/contacts.component.ts | Converts @input to model.required() and updates array operations |
| projects/demo/src/app/form3/contacts/contact/contact.component.ts | Converts @input to input.required() signals |
| projects/demo/src/app/form2/sample-data-form2.service.ts | Updates API endpoint and improves type definitions |
| projects/demo/src/app/form2/form2.component.ts | Updates to use new API endpoint and types |
| projects/demo/src/app/form2/form2.component.html | Converts control flow syntax and fixes option binding |
| projects/demo/src/app/form1/form1.component.html | Converts *ngIf to @if control flow |
| projects/demo/src/app/about.component.ts | Removes unused imports and OnInit implementation |
| angular.json | Removes polyfills configuration |
| .github/workflows/main.yml | Temporarily disables wireit caching |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.