FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Parse Lambda log messages by asprouse · Pull Request #1 · vectordotdev/timber-cloudwatch-logs-lambda-function · GitHub

This repository was archived by the owner on Dec 8, 2020. It is now read-only.

Parse Lambda log messages - #1

Open
asprouse wants to merge 1 commit into
vectordotdev:masterfrom
asprouse:master
Open

Parse Lambda log messages#1
asprouse wants to merge 1 commit into
vectordotdev:masterfrom
asprouse:master

Conversation

asprouse commented May 5, 2018

Copy link
Copy Markdown

This PR parses the Lambda usage report log messages. Perhaps there needs to be an environment variable to disable this behavior but it would seem that most people use this function to integrate with Lambda

zsherman requested a review from binarylogic May 5, 2018 18:37
ghost requested review from a user and removed request for binarylogic May 30, 2018 20:24
ghost assigned ghost and unassigned binarylogic May 30, 2018

ghost commented May 30, 2018

Copy link
Copy Markdown

@asprouse sorry for the delay in getting back to you on this.

Great work and I agree this is something most users would want and expect.

I only have one request, which is to namespace all custom contextual values under lambda. Right now we have lambda_start, lambda_end, etc., but I think it would be cleaner and more intuitive to have them all under lambda unless you have a specific use case in mind for the different event types.

Ultimately I think we will include lambda as a known context in our schema, but this is a good solution for the interim.

ghost commented May 31, 2018

Copy link
Copy Markdown

@asprouse scratch what I said before. We will be making schema changes related to lambda and then update this code accordingly.

Copy link
Copy Markdown
Author

@carkmorwin roger that. Let me know when the when the new version drops.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL