chore(core): remove obsolete const lint allows - #26128
Merged
thomasqueirozb merged 5 commits intoAug 20, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copilot stopped reviewing on behalf of
arfa79 due to an error
August 17, 2026 13:45
thomasqueirozb
approved these changes
Aug 17, 2026
thomasqueirozb
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
thomasqueirozb
enabled auto-merge
August 17, 2026 18:22
Copy link
Copy Markdown
Contributor
Author
@thomasqueirozb UW. Please enable auto merge again |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two obsolete clippy::missing_const_for_fn allowances by making the affected string getters const. The configurable template wrapper is also made const to preserve const propagation.
References
Related: #23659
Vector configuration
Not applicable; this is an internal Rust API cleanup with no configuration changes.
How did you test this PR?
The full all-features Clippy command was also attempted, but the local environment does not have cmake, which is required to build rdkafka-sys.
Is this a breaking change?
Does this PR include user facing changes?