| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Here are some automated review suggestions for this pull request.
Reviewed commit: 27f0a5c8d8
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
|
|
||
| .PHONY: generate-docs | ||
| generate-docs: generate-component-docs generate-vector-vrl-docs generate-vrl-docs | ||
| generate-docs: generate-component-docs generate-vector-vrl-docs generate-vrl-docs generate-example-configs |
There was a problem hiding this comment.
Commit the generated component examples
The new dependency generates website/generated/example-configs, but this commit tracks no files under that directory (verified with git ls-files). Consequently, make check-generated-docs creates the YAML files and then vdev check component-examples rejects them as untracked changes via get_files_changed_from_head, so the required generated-docs check fails on every clean checkout until the generated examples are committed.
AGENTS.md reference: AGENTS.md:L250-L256
Useful? React with 👍 / 👎.
Sorry, something went wrong.
| pub fn required_one_of(&self) -> Option<&str> { | ||
| self.attrs.required_one_of.as_deref() |
There was a problem hiding this comment.
Generate the required-one-of schema constraints
This accessor is never consumed by the schema generator: build_named_struct_generate_schema_fn still only maps fields into ordinary properties and returns generate_struct_schema, with no grouping or allOf/oneOf emission. As a result, the newly added smoke test cannot produce its expected constraint, and the remap and sample fields annotated with required_one_of never expose that relationship to generated docs or component examples.
AGENTS.md reference: AGENTS.md:L250-L256
Useful? React with 👍 / 👎.
Sorry, something went wrong.
| self.filter | ||
| .write() | ||
| .expect("rwlock poisoned") | ||
| .insert(&k.to_string()); |
There was a problem hiding this comment.
Enforce the Bloom filter entry limit
When more than max_entries distinct keys arrive, this loop continues inserting all of them; the option is only used to size the bitmap at construction and is never enforced. Since Bloom filters do not stop accepting values when their planned capacity is exceeded, this violates the documented maximum and drives the false-positive rate increasingly above the configured default, causing absent keys to be reported as present under sustained high-cardinality input.
Useful? React with 👍 / 👎.
Sorry, something went wrong.
There was a problem hiding this comment.
Here are some automated review suggestions for this pull request.
Reviewed commit: b354127b20
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
| - website_cargo_target:/target | ||
| environment: | ||
| - CI=false | ||
| - CARGO_TARGET_DIR=/target |
There was a problem hiding this comment.
Keep schema generation on Make's target path
When the documented docker compose up workflow runs, this variable sends Cargo's output to /target, but the newly invoked make generate-docs immediately executes the hard-coded target/debug/vector path in generate-component-docs. On a clean container that path does not exist, so startup stops after compilation instead of launching Hugo; either update the Make target to honor CARGO_TARGET_DIR or mount the cache at /app/target.
Useful? React with 👍 / 👎.
Sorry, something went wrong.
| # `prepare.sh` installs the matching vdev release or builds the checkout when it is unreleased. | ||
| ENTRYPOINT ["/bin/bash", "-lc", \ | ||
| "cd /app && git config --global --replace-all safe.directory /app && \ | ||
| scripts/environment/prepare.sh --modules=vdev,prettier,protoc && \ |
There was a problem hiding this comment.
Install protoc before generating docs
On a clean website image, passing protoc here does not install it: prepare.sh neither lists nor handles a protoc module, and the Docker package list omits protobuf-compiler. The following make generate-docs runs a default-feature cargo build; sources-dnstap enables protobuf-build, whose root build script invokes prost/tonic and requires protoc, so container startup fails before Hugo runs. Install protoc in the image or call the repository's install-protoc.sh explicitly.
Useful? React with 👍 / 👎.
Sorry, something went wrong.
| {{/* Fields whose value is source code (per their declared `syntax`) render their examples as a | ||
| highlighted code block so multi-line programs keep their newlines; jsonify would escape them | ||
| to a literal \n. Every other syntax renders inline as JSON. Map: syntax -> Chroma lexer. */}} | ||
| {{ $codeLexers := dict "vrl_program" "coffee" "lua" "lua" "yaml" "yaml" "toml" "toml" }} |
There was a problem hiding this comment.
Preserve remap_program rendering
On this release branch, the generated remap CUE still declares syntax: "remap_program", and reference.cue still permits that name rather than vrl_program. Consequently this lookup finds no lexer for the remap source example, which falls through to jsonify and renders a quoted string containing escaped \n sequences; the similarly renamed badge conditions also stop linking that field to the VRL docs. Retain remap_program here or port the producer and CUE schema changes in the same commit.
Useful? React with 👍 / 👎.
Sorry, something went wrong.
| ENTRYPOINT ["/bin/bash", "-lc", \ | ||
| "cd /app && git config --global --replace-all safe.directory /app && \ | ||
| scripts/environment/prepare.sh --modules=vdev,prettier,protoc && \ | ||
| make generate-docs && \ |
There was a problem hiding this comment.
Export CUE data before starting Hugo
On a clean docker compose up, website/data/docs.json is absent because it is gitignored. The old entrypoint explicitly exported the CUE tree into that file, but this replacement only runs the root generate-docs target, which regenerates CUE source files and never invokes website's cue-build; the direct hugo server call therefore has no site.Data.docs for templates such as the version and component pages. Run cue-build or the website's structured-data target before starting Hugo.
AGENTS.md reference: AGENTS.md:L141-L146
Useful? React with 👍 / 👎.
Sorry, something went wrong.
Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
| Back | FazBrowse Home | New Git URL |
Summary
Cherry-picks the post-v0.57 changes under website/ only:
It excludes unrelated source changes and unreleased generated documentation.
Vector configuration
Not applicable.
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
References
None.
Notes