FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update INSTALLFOLDER path to include publisher and title to match the documentation for PerMachine installs by jamesweston · Pull Request #873 · velopack/velopack · GitHub

Update INSTALLFOLDER path to include publisher and title to match the documentation for PerMachine installs - #873

Open
jamesweston wants to merge 1 commit into
velopack:developfrom
jamesweston:msi-install
Open

Update INSTALLFOLDER path to include publisher and title to match the documentation for PerMachine installs#873
jamesweston wants to merge 1 commit into
velopack:developfrom
jamesweston:msi-install

Conversation

Copy link
Copy Markdown

PR to fix #872

jamesweston marked this pull request as ready for review April 28, 2026 14:56

Copy link
Copy Markdown

@caesay Is there any reason why this is not merged yet?

caesay commented Jul 8, 2026

Copy link
Copy Markdown
Member

We are not sure that this is the correct approach, as this would be the first time the publisher field is used in application path's. It requires further consideration before we can move forward with this approach or possibly with some alternative like a package namespace.

Copy link
Copy Markdown

Understand, but correct me if I am wrong but then the documentation is wrong?

Copy link
Copy Markdown
Author

The documentation is why I submitted this as I was testing PerMachine installs and was not getting the install location stated in the documentation

Copy link
Copy Markdown

Why not add an option to vpk pack to set a custom default PerMachine path?

And while we're on the subject, it would also be great if there were an additional option for vpk pack that enables the installation user to select the installation path during the setup process for PerMachine installations.

What do you think?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSI Install Location

3 participants


Back | FazBrowse Home | New Git URL