mksession: link between shared views into a terminal buffer - #6930
Closed
bobrippling wants to merge 1 commit into
Closed
mksession: link between shared views into a terminal buffer#6930bobrippling wants to merge 1 commit into
bobrippling wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bobrippling
force-pushed
the
fix/mks-term
branch
from
634a958 to
c86655a
Compare
September 10, 2020 21:09
Copy link
Copy Markdown
|
Hi,
On Thu, Sep 10, 2020 at 2:02 PM Rob Pilling ***@***.***> wrote:
Before this commit, if a terminal buffer was visible in multiple windows,
a :mksession would generate a script which would not "re-link" these
terminal buffers, duplicating the command across the previously linked
windows.
This commit looks handles a terminal buffer that's open in multiple
windows, ensuring the buffer is shared between those windows when the
session is restored.
Can you add a test for this change?
Thanks,
Yegappan
… ------------------------------
You can view, comment on, or merge this pull request online at:
#6930
Commit Summary
- mksession: link between shared views into a buffer
File Changes
- *M* src/hashtab.c
<https://github.com/vim/vim/pull/6930/files#diff-f66fb35fb2e2837513621ac04f3678eb>
(2)
- *M* src/proto/terminal.pro
<https://github.com/vim/vim/pull/6930/files#diff-f99bbf5901acfc552c426972aa73bc9e>
(2)
- *M* src/session.c
<https://github.com/vim/vim/pull/6930/files#diff-c4be88194b2ccabe7ff34fece6d27ca7>
(114)
- *M* src/terminal.c
<https://github.com/vim/vim/pull/6930/files#diff-f83301fc7928a73575f006ec59a872b6>
(32)
Patch Links:
- https://github.com/vim/vim/pull/6930.patch
- https://github.com/vim/vim/pull/6930.diff
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Sure - added |
Sorry, something went wrong.
k-takata
reviewed
Sep 11, 2020
k-takata
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
coding style
Sorry, something went wrong.
Comment thread
src/terminal.c
Outdated
Comment thread
src/terminal.c
Outdated
Comment thread
src/terminal.c
Outdated
Before this commit, if a terminal buffer was visible in multiple windows, a `:mksession` would generate a script which would not "re-link" these terminal buffers, duplicating the command across the previously linked windows. This commit handles a terminal buffer that's open in multiple windows, ensuring the buffer is shared between those windows when the session is restored.
bobrippling
force-pushed
the
fix/mks-term
branch
from
8895ecf to
cecfc44
Compare
September 11, 2020 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, if a terminal buffer was visible in multiple windows, a :mksession would generate a script which would not "re-link" these terminal buffers, duplicating the command across the previously linked windows.
This commit looks handles a terminal buffer that's open in multiple windows, ensuring the buffer is shared between those windows when the session is restored.