Support endless operator methods - #463
Merged
AndrewRadev merged 1 commit intoDec 21, 2024
Merged
AndrewRadev merged 1 commit into
AndrewRadev merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
AndrewRadev
reviewed
Dec 12, 2024
Comment thread
spec/indent/method_definitions_spec.rb
Outdated
Copy link
Copy Markdown
Member
|
Thank you for your contribution, I didn't consider operator definitions when I worked on endless indenting. The test seems to fail for me at some point, does it pass for you or is the PR incomplete? |
Sorry, something went wrong.
etiennebarrie
force-pushed
the
endless-operators
branch
from
327ad0d to
7c31ea2
Compare
December 19, 2024 23:21
Copy link
Copy Markdown
Contributor
Author
|
The PR was incomplete, sorry. The test should now pass. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks, I can confirm the tests are passing, and the regex looks sensible. I'll merge this and we'll see if any issues come up. 👍 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.