FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clean up builds on travis by lucc · Pull Request #384 · vim-vdebug/vdebug · GitHub

/ vdebug Public

Clean up builds on travis - #384

Open
lucc wants to merge 31 commits into
vim-vdebug:masterfrom
lucc:travis
ConversationCommits (31)ChecksFiles changed
Open

Clean up builds on travis#384
lucc wants to merge 31 commits into
vim-vdebug:masterfrom
lucc:travis

Conversation

lucc commented Oct 6, 2018

Copy link
Copy Markdown
Contributor

I cleaned up and commented the travis file. Results:

  • less needless options (docker exec --tty)
  • less installed packages
  • less packages installed outside of the distro package manager
  • less inline shell scripts and less quotes
  • no sudo inside container (together with local bundler installation of requirements)
  • separation of test commands to make failures easier to understand
  • explicit comments why we need locale-gen and su

Further questions about the travis build:

  • Should we also run the tests on more distros? See the example for ubuntu 18.04 on travis
  • Should we run tests on macOS? Travis can do that and I could update the travis file for that.
  • Should we run the ubuntu tests on travis directly, without docker to reduce overhead and speed things up? (This is especially interesting if we also run tests on macOS as these would probably run without docker which would force us to implement different build logics anyways.)

Questions about the tests (in general and on travis):

  • It looks like the features from the ruby tests are all empty. There is no actual testing going on. We should fix that! But I don't know any ruby 😞
  • One of the spec test is flaky and fails randomly on travis. Do you have any idea how we can fix that?

lucc added 8 commits October 5, 2018 11:20
Split long docker commands
02cd86f 
This way travis gives a better indication which command failed.  Also it
makes the lines shorter and easier to read.
Remove travis gem from requirements
2f2b6a9 
The gem is used to interact with travis.ci which is not strictly
necessary to test vdebug (even if the tests run on travis).  This also
makes some dependencies obsolete as they where only needed for the
travis gem.
Install bundler and coverage with apt
8ea61e7
Local bundler install
2abe482 
This makes sudo and the setup of sudo unnecessary.
Do not allocate a tty for docker commands
10d5a5c 
Apt needs a special environment variable to work but the other commands
do not need a tty.
Separate flaky tests from other tests
808cbb2 
The ruby specs in spec/startup_spec.rb fail randomly on travis so we
execute the specs separated from the feature tests.  That way rake will
not stop after the failure.
Clean up locale setup and usage
3905978 
The package installation with bundler does not require a full login
session from su so it can be run with sh.
Fix startup of xvfb if display is not free
74b2387

BlackIkeEagle commented Oct 18, 2018

Copy link
Copy Markdown
Member

Further answers about the travis build:

  • Yes we should run tests on more distro's
  • macOS would be a nice to have
  • at the time of the switch to docker the travis base was using an outdated version of vim compiled against python2, so if this is now improved, it could be switched back to non-docker

Answers to questions about the tests (in general and on travis):

  • I was going to look into that, but did not find sufficient large blocks of time to get into it
  • The flaky test is a very travis + docker specific issue, if docker is remove again from the tests that will fix itself

lucc commented Nov 30, 2018

Copy link
Copy Markdown
Contributor Author

I started to play around with this again. What motivated me where some changes from travis' side: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration

If we want to run tests on OSX we will not be able to use language: python: travis-ci/travis-ci#2312 . This means we can not use stuff like this to construct a nice build matrix (which we did not use until now anyways):

python:
 - "3.4"
 - "3.5"
 # ...

But which might still be interesting as it should start a different VM with that python version preinstalled so the install step could be faster.

I think we have to decide between two options:

  • use language: python with different python versions only on linux
  • one python version but on linux and on osx with language: minimal

@BlackIkeEagle What do you think? What might be more important to test regarding frequent bug reports?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL