| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
|
Sorry, something went wrong.
|
After 2866d4f, we have opt-in for build plugins to be shared, matching the way things work during dev. We can deprecate config.build for ResolvedBuildOptions because these are the defaults and shouldn't be used. And later on directly remove config.build after resolving forcing everyone to use environment.options (this is the same we already were discussing to with config.resolve). I think this may be one of the trickiest parts in getting the ecosystem to move. We could always leave an opt-in into backward compatibility when we reach this point. One interesting problem about shared plugins is that once they are used, the only command that makes sense is vite build --app. Building a single environment could fail because the author of the plugin has the expectation of the plugin processing both client and ssr code for example. This is equivalent to what happens now in SvelteKit and other frameworks where building only ssr doesn't work because you need to build the client first, get the SSR manifest and use it to build the ssr (and they do all this in a single vite build). |
Sorry, something went wrong.
Co-authored-by: patak-dev <matias.capeletto@gmail.com>
|
/ecosystem-ci run |
Sorry, something went wrong.
|
📝 Ran ecosystem CI on 0250864: Open
✅ analogjs, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress |
Sorry, something went wrong.
|
Current ecosystem CI state in the Environment API PR. We're all green in main, so we know that these are produced by the new changes:
Note: SvelteKit was passing before, it is failing in main now too. It is unrelated to this PR. |
Sorry, something went wrong.
|
We discussed in today's Vite team meeting that we should merge this PR so we move further work to main. The changes in this PR are now backward compatible (see ecosystem-ci comment above) and all new APIs are experimental. We can continue refining them during the Vite 6 beta period that we will start now (and even after the stable release, we'll have opportunities for changes if needed until these are stabilized in 6.x). |
Sorry, something went wrong.
There was a problem hiding this comment.
Let's go! 🔥
Sorry, something went wrong.
|
@Scutua please don't approve old PRs in the repo, or we'll need to ban you from the org for spamming. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description
Note
Check out the Environment API Docs
We're starting a new PR for the Environment API work in progress proposal for v6 to have a clean slate for reviews and discussions now that the implementation and docs are more stable.
This PR merges the work done in:
Refer to the discussions in these PRs for context. If you have general feedback about the APIs, let's use this discussion so we can have proper threads:
If you have comments about the implementation or would like to collaborate a feature, fix, test, or docs, please comment in this PR as an usual review or send a PR against the v6/environment-api branch.
Ecosystem Compatibility
These projects are failing in CI because of known reasons.