fix(plugin-rsc): skip build-only generateBundle in bundledDev - #1296
Open
mellyeliu wants to merge 2 commits into
Open
mellyeliu wants to merge 2 commits into
mellyeliu wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
In bundledDev mode the client environment runs a Rollup build while mode === 'dev', so the assets-manifest generateBundle hook fires even though no RSC build output exists. It then reads manager.bundles['rsc'] (populated only by a production build) and crashes with 'TypeError: Cannot convert undefined or null to object'. The dev manifest is already served by the load hook, so the build-only asset copying and buildAssetsManifest construction are unnecessary in dev. Return early when mode === 'dev'.
Reuses examples/basic with 'pnpm dev --experimental-bundle' and asserts the dev server starts, renders, and hydrates without the generateBundle crash.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
experimental.bundledDev: true crashes the dev server on startup:
TypeError: Cannot convert undefined or null to object at generateBundle (virtual:vite-rsc/assets-manifest)The assets-manifest manifest is served two ways: the load hook builds it in dev, and generateBundle builds it in production from manager.bundles['rsc']. In normal dev, generateBundle never runs. In bundledDev the client environment runs a Rollup build while mode === 'dev', so generateBundle fires, but there's no RSC build, so manager.bundles['rsc'] is undefined and Object.values(rscBundle) throws.
The fix is to return early from generateBundle in dev, since the load hook already provides the manifest there.
(Production builds and are unaffected)
Testing