fix: ignore failures on writeToCache - #7893
Merged
sheremet-va merged 1 commit intoMay 5, 2025
Merged
sheremet-va merged 1 commit into
sheremet-va merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The cache is not mandatory. No reason to abort when it fails. This can happen when node_modules is not writable for example.
Copy link
Copy Markdown
Contributor
Author
|
This change together with vitejs/vite#19952 allows running tests in docker, when running as a different user than the one used in the image (usually root or node, with uid 1000). |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
I think this should be possible today with vitest --configLoader runner and custom cacheDir https://stackblitz.com/edit/vitest-dev-vitest-t9e1fblp?file=vite.config.ts |
Sorry, something went wrong.
sheremet-va
approved these changes
May 5, 2025
1 task
1 task
This was referenced Jun 2, 2025
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache is not mandatory. No reason to abort when it fails.
This can happen when node_modules is not writable for example.
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests